Firefox Bookmark runner

[Sebastian Kügler]

On Monday 02 November 2009 14:05:39 Jan Gerrit Marker wrote:
> Am Montag 02 November 2009 13:53:35 schrieb Sebastian Kügler:
> > > You could have two methods:
> > > QList<Plasma::QueryMatch> firefoxBookmarks(QString& term);
> > > QList<Plasma::QueryMatch> konquerorBookmarks(QString& term);
> > >
> > > The match Method tests if Firefox or Konqueror should be asked for
> > >  bookmark  information and runs the methods. Then it calls
> > >  context.addMatches() and adds the matches it got from the method.
> > >
> > > But the idea of a single bookmark runner is good. That would be much
> > >  easier.
> >
> > 
> > I (as the original developer of the konqi bookmark runner) think it's a
> >  good idea.
> > 
> 
> Oh, didn't know that you are the developer.
> In this case, are you ok with the way is suggested?
> How should we merge them? And when? (My time as KDE developer isn't that 
> long...)

No problem. You can just make the changes to the runner (and possibly give it a more 
generic name). If you got it working, post the patch to reviewboard. Assuming it's 
OK, we'll merge it.

Since soft feature freeze is looming, if you intend to merge it after November 4th 
(likely), please add it to the feature plan on 
http://techbase.kde.org/Schedules/KDE4/4.4_Feature_Plan

If you've questions, you can just ask here.

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9