Review Request: Comic applet proted to PopupApplet

[Giulio Camuffo]

In data sabato 31 ottobre 2009 10:11:47, Marco Martin ha scritto:
: > On Saturday 31 October 2009, Aaron J. Seigo wrote:
> > On October 30, 2009, Giulio Camuffo wrote:
> > > In data venerdì 30 ottobre 2009 18:03:07, Aaron J. Seigo ha scritto:
> > > : > On October 30, 2009, Giulio Camuffo wrote:
> > > : >
> > > > > So this patch fixes this.
> > > >
> > > > i think you forgot the patch
> >
> > it looks good except for setting a minimum size of 20x20. that's a bit
> > too big for people who will be wanting 16px tall panels :) set it to 8x8
> > if anything?
> 
> shouldn't be done in popupapplets with icon, if at all?
> 

removed the minimum size
-------------- next part --------------
A non-text attachment was scrubbed...
Name: comic.patch
Type: text/x-patch
Size: 19761 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20091101/fdbaab33/attachment-0001.patch