Review Request: Add a tooltip to battery monitor applet

Kåre Särs kare.sars at iki.fi
Sun Nov 1 09:04:13 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2010/
-----------------------------------------------------------

(Updated 2009-11-01 08:04:09.930792)


Review request for Plasma.


Changes
-------

I did the suggested changes and added a if (m_showRemainingTime &&...) around the "Estmated time remaining".

If the "Estmated time remaining" is not accepted I can remove it.


Summary
-------

This path adds a tool-tip for the battery-monitor applet. The tool-tip contains charge percentage and estimated time left. The patch also changes the CMakeLists.txt to make it possible to compile the applet standalone. 


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.h 1041319 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/battery/battery.cpp 1041319 

Diff: http://reviewboard.kde.org/r/2010/diff


Testing
-------

I'm not running trunk, so I had to comment out the setStatus() functions (not done in the patch).


Thanks,

Kåre



More information about the Plasma-devel mailing list