Kickoff fix

[dantti85-dev at yahoo.com.br]

What about doing the old test (isLocalFile || isRelativePath()), this would
keep the old behavior and add support for relative paths, i believe
something like http://path_to/thing.desktop will never be relative?

Daniel.



----- Mensagem original ----
De: Aaron J. Seigo <aseigo at kde.org>
Para: plasma-devel at kde.org
Enviadas: Domingo, 31 de Maio de 2009 2:50:25
Assunto: Re: Kickoff fix

On Saturday 30 May 2009, dantti85-dev at yahoo.com.br wrote:
> The url for these relative paths are like
> "Internet/kvirc.desktop", and how does
> that http://foo/.../thing.desktop works? I mean
> how can one input those?

that method is used for the creation of items for most of the views, and it's 
not hard to get such urls in, for instance, recently used documents.

> We can test the url protocol but it actually depends more
> on it being passed, like these relatives don't pass.

sure; but in the case of the relative path, what does protocol() return? i 
imagine an empty string? probably checking for either file or QString() would 
work?

> This patch is not completely actually, after i sent
> the email, i remembered that i forgot to put code to
> add it to panel, (but it's quite easy to fix..), I'll try to finish
> tomorrow.

"add to panel" and "add to desktop" is such a horrible hack it's not even 
funny. i really wish, in retrospect, that i'd been a bit stricter and not let 
those feature/bugs in. i was catching enough flak from the people who were 
contributing such patches at the time that i eventually just gave in. *sigh*

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software


      Veja quais são os assuntos do momento no Yahoo! +Buscados
http://br.maisbuscados.yahoo.com