Review Request:

Jacopo De Simoi wilderkde at
Thu May 28 17:59:52 CEST 2009

This is an automatically generated e-mail. To reply, visit:

Review request for Plasma and Aaron Seigo.


Krunner has some issues with the TAB key; KLineEdit autocompletes automatically when losing focus, so the overall behavior is confusing.
This patch filters the tab events and introduces a consistent behavior;
I am personally not 100% sure about what would be the "expected" behavior, so I ask for a review;
the patch has comments to explain the various cases.
Any comment is welcome. Should I ask also on kde-usability?

This addresses bug 192605.


  trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 973024 
  trunk/KDE/kdebase/workspace/krunner/interfaces/default/krunnertabfilter.h PRE-CREATION 
  trunk/KDE/kdebase/workspace/krunner/interfaces/default/krunnertabfilter.cpp PRE-CREATION 
  trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp 973024 



Done basic testing and it works



More information about the Plasma-devel mailing list