knotificationitem: api prettiness

[Richard Moore]

On Wed, May 27, 2009 at 12:27 PM, Aaron J. Seigo <aseigo at kde.org> wrote:
> On Tuesday 26 May 2009, Marco Martin wrote:
>> 1) we have two way to set icons: by name and by pixmap, right now by name
>> is setIcon()
>> by pixmap is setImage()
>> (that should reflect in dbus too)
>> that looks a bit weird, would be better maybe setIconName() and setIcon()?
>
> another proposal:
>
> setIconByName
> setIconByPixmap
>
> that way we don't end up with a setIcon(QIcon) that the compiler would use
> silently when someone ports from KSystemTray to KNotificationItem (we really
> want to discourage use of the setIcon(QIcon) method) and it says exactly what
> it's doing.

This is a kind of +0.5. I can see the setters, but iconByName() and
iconByPixmap() seem a bit odd.

Rich.