knotificationitem: api prettiness

Marco Martin notmart at gmail.com
Tue May 26 23:17:57 CEST 2009


Hi all,
was talking with richmoore about the api of libknotificationitem, wat did 
emerged is a thing i wasn't happy about but couldn't quite quantify before:

1) we have two way to set icons: by name and by pixmap, right now by name is
setIcon()
by pixmap is setImage()
(that should reflect in dbus too)
that looks a bit weird, would be better maybe setIconName() and setIcon()?

2)  void showMessage(const QString &title, const QString &message, const 
QString &icon, int timeout = 10000);

should become

void showMessage(const QString &message, const QString &title = QString(), 
const QString &icon = QString(), int timeout = 10000);

anything else important i forgot?


aaand, can quite big changes like the icon methods still be done?
and when? now? after 4.3?

Cheers,
Marco Martin


More information about the Plasma-devel mailing list