Python Applet and configChanged

[Aaron J. Seigo]

On Tuesday 26 May 2009, Petri Damstén wrote:
> plasmoidviewer with python applet start (configChanged called 4 times):

hm... too many calls to writeConfig are happening, and KConfigSkeleton is Too 
Dumb(tm) to know that nothing's actually changed. i'll take a look in a bit 
about this.

(i don't think it should be called at all on startup, actually)

> config dialog ok pressed after changing data (configChanged called 3
> times):

right, we probably don't need the applet to also say the config has changed if 
(but only if!) we have a config loader, so something like this in 
AppletPrivate::configDialogFinished():

if (!configLoader) {
    // manually call configChanged, otherwise let the loader do that for us
    q->configChanged();
}

does that fix it for you properly?

another approach might be to just not forward the configChanged signal from 
KConfigSkeleton at all, but i'm concerned that will just open up other edge 
cases when a script actually does trigger a config change without using the 
config dialog or if/when KConfig gets change notification.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090526/cdd90c2b/attachment.sig