Review Request: Sorting of Favourites in launcher will be saved

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/690/#review1115
-----------------------------------------------------------



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/favoritesmodel.cpp
<http://reviewboard.kde.org/r/690/#comment729>

    before changing the list, i'd probably do a check first for Private::models.isEmpty(), maybe even at the start of the method:
    
    if (Private::models.isEmpty()) {
        return;
    }



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/favoritesmodel.cpp
<http://reviewboard.kde.org/r/690/#comment727>

    Private::globalFavoriteList.clear();



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/favoritesmodel.cpp
<http://reviewboard.kde.org/r/690/#comment728>

    don't need to do this for every model; they have the same contents. it's enough to do it for just the first model:
    
    FavoritesModel *model = Private::models.first();



trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/favoritesmodel.cpp
<http://reviewboard.kde.org/r/690/#comment730>

    this doesn't seem to be used or necessary?


- Aaron


On 2009-05-13 02:49:03, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/690/
> -----------------------------------------------------------
> 
> (Updated 2009-05-13 02:49:03)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This patch is regarding the bug 189607. This patch will enable saving the sorted Favorites.
> 
> 
> This addresses bug 189607.
>     https://bugs.kde.org/show_bug.cgi?id=189607
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/favoritesmodel.cpp 967123 
> 
> Diff: http://reviewboard.kde.org/r/690/diff
> 
> 
> Testing
> -------
> 
> Done basic testing by adding new items to favourites and deleting. It worked.
> 
> 
> Thanks,
> 
> Sujith
> 
>