Review Request: Adaptive Search for KRunner

[Aaron Seigo]

> On 2009-05-13 08:41:21, Aaron Seigo wrote:
> > /trunk/KDE/kdelibs/plasma/runnermanager.cpp, lines 345-348
> > <http://reviewboard.kde.org/r/694/diff/1/?file=6365#file6365line345>
> >
> >     if this became d->context->run(match), which i think makes sense since match belongs to the context, then increaseLaunchCount can be kept interna to Context.
> 
>  wrote:
>     I was initially loath to add yet another run method because I was worried it might be confusing for users with so many public run methods. Would it make sense to declare RunnerManager as a friend and keep the run method private? I don't see many people calling context.run(match) on their own.

i was trying to avoid the friending situation, if only because that makes RunnerContext usable only from RunnerManager. i'm not sure that should be the case; or rather, if it is, then why is RunnerContext public API at all? :)

in this case i'd go for the API addition.

(btw, if we did go the friending route then all the new api could be put into RunnerContextPrivate)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/694/#review1107
-----------------------------------------------------------


On 2009-05-13 07:13:18, Ryan Bitanga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/694/
> -----------------------------------------------------------
> 
> (Updated 2009-05-13 07:13:18)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This enables adaptive search for KRunner by tracking user behavior in terms of programs run, documents opened, etc. via KRunner. It boosts relevance of a match whenever a user runs that match, allowing the match to appear before other matches obtained of similar nature as long as the front-end correctly sorts the matches.
> 
> For example, running a query of "kon" on the services runner may result in matches for Konqueror and Konsole. Both matches will have a relevance of 1.3, but Konqueror will appear before Konsole. If a user launches Konsole via KRunner at least one time more than Konqueror, Konsole will have its relevance boosted and will appear before Konqueror in the list of matches.
> 
> This partially addresses bug #180158. The other part (changes to quicksand) will be committed soon.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/querymatch.cpp 967300 
>   /trunk/KDE/kdelibs/plasma/runnercontext.h 967300 
>   /trunk/KDE/kdelibs/plasma/runnercontext.cpp 967300 
>   /trunk/KDE/kdelibs/plasma/runnermanager.cpp 967300 
> 
> Diff: http://reviewboard.kde.org/r/694/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryan
> 
>