Review Request: use buttons instead of links in systray notifications

Aaron Seigo aseigo at kde.org
Mon May 11 22:07:21 CEST 2009



> On 2009-05-10 13:18:35, Aaron Seigo wrote:
> > hm.. how about a close symbol in the group header, which would then close the whole group, just as closing one item closes a single item?
> 
> Marco Martin wrote:
>     done, looks nice indeed.
>     but i wonder if it wouldn't cause some accidental clear when the user wants just to hide it tough.

hopefully there'd be some spacing between them?


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/686/#review1102
-----------------------------------------------------------


On 2009-05-11 03:47:16, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/686/
> -----------------------------------------------------------
> 
> (Updated 2009-05-11 03:47:16)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> the links for more/less info and "clear all" completed jobs looks really ugly, normal pushbuttons seem to look a bit better.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.h 966519 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp 966519 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 966519 
> 
> Diff: http://reviewboard.kde.org/r/686/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/686/s/117/
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Plasma-devel mailing list