Review Request: Notes plasmoid: change text color before any text, new color is now honored
Anne-Marie Mahfouf
annma at kde.org
Sat May 9 13:47:06 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/679/
-----------------------------------------------------------
(Updated 2009-05-09 04:47:06.598306)
Review request for Plasma.
Summary
-------
The upstream Qt bug is fixed but it did not fix the Notes applet. This patch makes a change of color before any text honored. Also when you remove all text and change color, the new text gets the new color. A bit ugly as it messes with QTimer but I don't see another way around this.
Please check it: before the patch, set a Notes applet, change text color, write text: text is black. After patch: text is the new color.
This addresses bug 176266.
https://bugs.kde.org/show_bug.cgi?id=176266
Diffs (updated)
-----
/trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 965525
Diff: http://reviewboard.kde.org/r/679/diff
Testing
-------
Thanks,
Anne-Marie
More information about the Plasma-devel
mailing list