Review Request: Separator widget.

[Ivan Cukic]

> On 2009-05-05 15:55:37, Aaron Seigo wrote:
> > this will have to wait for 4.4 at this point, but it seems like a good idea. any reason why this would use an svg? could we get away with a simple QPainter drawing using Theme colours?

Using a hard-coded painting would be strange concerning that everything else is themable.

As for use-cases, one theme would want to show a dot (or three dots - like Oxygen had for toolbar separators before 4.0, and before the Great Divide), and not a line, one theme would like to show a gradient line (most opaque in the middle), or a perspective rectangle to give a feel of depth...


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/672/#review1067
-----------------------------------------------------------


On 2009-05-05 08:36:37, Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/672/
> -----------------------------------------------------------
> 
> (Updated 2009-05-05 08:36:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Separator widget is a separator line widget.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/CMakeLists.txt 963819 
>   /trunk/KDE/kdelibs/plasma/widgets/separator.h PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/widgets/separator.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/672/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>