Review Request: FIXME part of quicklaunch

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/#review1070
-----------------------------------------------------------



trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp
<http://reviewboard.kde.org/r/649/#comment714>

    the easiest way i can think of doing this (even if its not super fast, which doesn't matter because there are small #s of items here):
    
    for (int i = 0; i < m_dialogLayout->count(); ++i) {
        QGraphicsLayoutItem *item = m_dialogLayout->itemAt(i);
        if (item->geometry().contains(pos)) {
            m_dialogLayout->insertItem(dropedItem, i + 1);
            break;
        }
    }


- Aaron


On 2009-05-05 12:28:07, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/649/
> -----------------------------------------------------------
> 
> (Updated 2009-05-05 12:28:07)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had added one more method named dropApp. Added the processDrop as per Aaron seigo. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 963461 
>   trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 963461 
> 
> Diff: http://reviewboard.kde.org/r/649/diff
> 
> 
> Testing
> -------
> 
> Done basic testing and it works.
> 
> 
> Thanks,
> 
> Sujith
> 
>