Review Request: config

[Chani]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/639/
-----------------------------------------------------------

(Updated 2009-05-01 19:49:49.223570)


Review request for Plasma.


Changes
-------

it's modal! :D relies on http://reviewboard.kde.org/r/652/ though.
I also fixed a problem due to some recent change in kdelibs... having the corona actions also in the containment collection was clobbering their keyboard shortcuts. the hack to avoid that is... kinda ugly, though.
oh, and this patch doesn't include the plasma-desktop changes... err... oh crap. kshortcutsdialog is given corona's actioncollection before plasmaapp adds to it, and so those shortcuts never show up in the dialog. um. anyone got an idea for solving that? a way to delay adding it until plasmaapp has had a chance to do stuff, perhaps?


Summary (updated)
-------

-plasmaapp's corona actions are left out
-needs testing without my local patch that fixes a qt shortcut bug


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/applet.h 961912 
  /trunk/KDE/kdelibs/plasma/applet.cpp 961912 
  /trunk/KDE/kdelibs/plasma/containment.cpp 961912 
  /trunk/KDE/kdelibs/plasma/corona.h 961912 
  /trunk/KDE/kdelibs/plasma/corona.cpp 961912 
  /trunk/KDE/kdelibs/plasma/private/applet_p.h 961912 
  /trunk/KDE/kdelibs/plasma/private/containment_p.h 961912 

Diff: http://reviewboard.kde.org/r/639/diff


Testing
-------


Thanks,

Chani