Review Request: Add keyboard navigation to plasma applet Folder View

[Shantanu Tushar Jha]

> On 2009-03-20 14:07:32, Fredrik Höglund wrote:
> > /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1255
> > <http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1255>
> >
> >     The implementation of this function suffers from the same problem as the one above.
> >     It should also use the smoothScroll() function instead of changing the scrollbar value directly.
> >     
> >     I would implement it by doing something like:
> >     
> >     const QRect r = mapFromViewport(visualRect(index));
> >     if (r.top() < 0) {
> >         smoothScroll(0, r.top());
> >     } else if (r.bottom() > geometry().height()) {
> >         smoothScroll(0, r.bottom() - geometry().height());
> >     }
> >

I've reverted whole of this back, and currently will work on this problem of user having rearranged the icons. Will submit a new patch when I'm done.


- Shantanu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/#review541
-----------------------------------------------------------


On 2009-03-20 22:14:51, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/368/
> -----------------------------------------------------------
> 
> (Updated 2009-03-20 22:14:51)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This partly addresses the above bug, adding keyboard navigation and launch using Enter key.
> Please report if the code is too complex, I've tried my best to keep it to the point.
> 
> 
> This addresses bug 187241.
>     https://bugs.kde.org/show_bug.cgi?id=187241
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 942106 
>   /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 942106 
> 
> Diff: http://reviewboard.kde.org/r/368/diff
> 
> 
> Testing
> -------
> 
> Tested on latest SVN build. Navigation and launch work fine. The problem is with movement of the scrollbar with the keyboard focus, the scrollbar refuses to go to minimum value when m_scrollBar->setValue( m_scrollBar->minimum() ); is used. What am I doing wrong?
> 
> 
> Thanks,
> 
> Shantanu
> 
>