Review Request: Show menu titles in classic style menu

Aaron Seigo aseigo at kde.org
Sun Mar 29 20:57:03 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/455/#review699
-----------------------------------------------------------

Ship it!


the config dialog layout needs to adjusted. otherwise looks good :)


Screenshot: Settings dialog with new option
<http://reviewboard.kde.org//r/455/#scomment21>
    it should be:
    
      Show menu titles: [  ]
    
    with the label right aligned with the others.


Screenshot: Settings dialog with new option
<http://reviewboard.kde.org//r/455/#scomment22>
    not related to this patch, but i just noticed that the capitalization is incorrect in this one. "Recently used applications:"

- Aaron


On 2009-03-28 05:36:08, Christian Loose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/455/
> -----------------------------------------------------------
> 
> (Updated 2009-03-28 05:36:08)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds a new option to show KDE3-like menu titles in the classic style menu (simplelauncher).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/simpleapplet.cpp 945836 
> 
> Diff: http://reviewboard.kde.org/r/455/diff
> 
> 
> Testing
> -------
> 
> Tested with svn trunk.
> 
> 
> Screenshots
> -----------
> 
> Settings dialog with new option
>   http://reviewboard.kde.org/r/455/s/76/
> classic style menu with titles
>   http://reviewboard.kde.org/r/455/s/79/
> 
> 
> Thanks,
> 
> Christian
> 
>



More information about the Plasma-devel mailing list