Review Request: Makes the configuration of the comic plasmoid easier to use

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/461/#review685
-----------------------------------------------------------

Ship it!


looks good.
i would skip the select all button for now

- Marco


On 2009-03-29 04:33:47, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/461/
> -----------------------------------------------------------
> 
> (Updated 2009-03-29 04:33:47)
> 
> 
> Review request for Plasma and Davide Bettio.
> 
> 
> Summary
> -------
> 
> Whenever the user ticks "Use Tabs" the view changes and the available comics are displayed in a listview, clicking at them marks them and adds them as tabs if ok is pressed. Otherwise it is similar to the current situation.
> 
> I'm not sure if I should add "Select All"-, "Deselect All"-Buttons. What do you think?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 946187 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 946187 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comicSettings.ui 946187 
>   /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h 946187 
>   /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp 946187 
> 
> Diff: http://reviewboard.kde.org/r/461/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/461/s/82/
> 
>   http://reviewboard.kde.org/r/461/s/83/
> 
> 
> Thanks,
> 
> Matthias
> 
>