Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review654
-----------------------------------------------------------


great! a few small issues to take care of; the next step is now to read the value when the applet is created. that should go into void Launcher::setApplet(Plasma::Applet *applet) in ui/launcher.cpp. 

then modify ApplicationModel (in core/applicationmodel.cpp) to have the order set (e.g. setNameDisplayOrder(DisplayOrder) where DisplayOrder would be an enum (there's a FormatType enum in simpleapplet/simpleapplet.h that maybe could be moved somewhere in core/?), and then in ApplicationModel::data, return the name or generic name based on that setting.

that should complete the feature :)


/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
<http://reviewboard.kde.org/r/441/#comment415>

    please put each declaration on its own line:
    
    QCheckBox *switchOnHoverCheckBox;
    QCheckBox *appByNameCheckBox;



/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
<http://reviewboard.kde.org/r/441/#comment416>

    the Launcher class (in ui/launcher.*) will need a bool showAppsByName() const; method in it to use here.



/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
<http://reviewboard.kde.org/r/441/#comment417>

    minor niggle, but should probably be ShowAppsByName. hm... ListAppsByName might be even more natural.
    
    though to future proof this, i'd probably use a string value and do something like:
    
    cg.writeEntry("AppListingStyle", showAppByName ? "NameFirst" : "DescriptionFirst");
    
    that way if we add more ways to list the apps later we don't have odd config files :)


- Aaron


On 2009-03-27 12:37:45, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/441/
> -----------------------------------------------------------
> 
> (Updated 2009-03-27 12:37:45)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see "Audio Player - Amarok". But he requested it to be in other way "Amarok - Audio Player". Hence as an initial step he asked me to add a check box similar to "Switch tabs on hover". I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 945188 
> 
> Diff: http://reviewboard.kde.org/r/441/diff
> 
> 
> Testing
> -------
> 
> I had compiled the above patch in my build directory. It compiled without any errors. 
> 
> 
> Thanks,
> 
> Sujith
> 
>