Review Request: Add CheckBox wrapper for Plasma toolbox

[Alain Boyer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/428/
-----------------------------------------------------------

(Updated 2009-03-26 20:47:03.220349)


Review request for Plasma.


Changes
-------

Removed the style update from the paint method. It still remains a little awkward since initStyleOption() does not seem to work properly when called from the constructor.


Summary
-------

This patch adds a wrapper around QCheckBox much like the current ToolButton wrapper. The rational is that the existing label for "Different activity for each desktop" is always displayed in black when zoomed out and using the Oxygen Plasma theme. With this change, the label colour now respects Plasma::Theme::TextColor.

Is there any reason why we are not using the Plasma::CheckBox and Plasma::PushButton widgets here?


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/shells/desktop/CMakeLists.txt 944909 
  trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.h PRE-CREATION 
  trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.cpp PRE-CREATION 
  trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp 944909 

Diff: http://reviewboard.kde.org/r/428/diff


Testing
-------

Switched between the Air and Oxygen themes and the label remains visible, switching between black and white respectively.


Thanks,

Alain