Review Request: Add CheckBox wrapper for Plasma toolbox

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/428/#review628
-----------------------------------------------------------


yes, this needs to be fixed; they aren't using Plasma::Widgets because they are regular QWidgets and not widgets-on-canvas. that could be changed, of course, and might make sense as well: create an offscreen (Corona::addOffscreenWidget) set of widgets and display them in a QGraphicsWidget. this may or may not be awkward if this toolbox is managed by the View rather than the Corona. if so, then the toolbox could be created and managed by DesktopCorona in workspace/plasma/shells/desktop/


trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.cpp
<http://reviewboard.kde.org/r/428/#comment407>

    can the pallete just be set in the ctor? or even better, just set when the checkbox is created? that should avoid the need for a subclass.


- Aaron


On 2009-03-26 09:43:50, Alain Boyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/428/
> -----------------------------------------------------------
> 
> (Updated 2009-03-26 09:43:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds a wrapper around QCheckBox much like the current ToolButton wrapper. The rational is that the existing label for "Different activity for each desktop" is always displayed in black when zoomed out and using the Oxygen Plasma theme. With this change, the label colour now respects Plasma::Theme::TextColor.
> 
> Is there any reason why we are not using the Plasma::CheckBox and Plasma::PushButton widgets here?
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/shells/desktop/CMakeLists.txt 944909 
>   trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/shells/desktop/checkbox.cpp PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp 944909 
> 
> Diff: http://reviewboard.kde.org/r/428/diff
> 
> 
> Testing
> -------
> 
> Switched between the Air and Oxygen themes and the label remains visible, switching between black and white respectively.
> 
> 
> Thanks,
> 
> Alain
> 
>