Review Request: Plasma::AbstractRunner::Syntax

[Dario Freddi]

On Tuesday 24 March 2009 20:03:25 Aaron Seigo wrote:
> so i'd like to keep addSyntax as that keeps the runners simpler, but add a
> setSyntaxes and removing clearSyntaxes does make sense ... thoughts?

I'm fine with keeping addSyntax and adding setSyntaxes (I proposed something 
similar before iirc), but not in removing clearSyntaxes. To me, the options 
are:
 
 - keep both add and clear
 - ditch both add and clear

Since if I had to rely on add only and had to change my queries (one never 
knows), I'd need to use clear. Otherwise, if I had to use set to remove them, 
for what it's worth I wouldn't even use add in the first place.

>
>
> - Aaron
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/372/#review585
> -----------------------------------------------------------
>
> On 2009-03-20 13:13:37, Aaron Seigo wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/372/
> > -----------------------------------------------------------
> >
> > (Updated 2009-03-20 13:13:37)
> >
> >
> > Review request for Plasma.
> >
> >
> > Summary
> > -------
> >
> > Allows runners to register their syntax so that it can be displayed to
> > the user, and perhaps even used in the future to automate the process of
> > deciding whether a runner should actually be activated or not.
> >
> > :q: is used to mean "the search term" in the texts.
> >
> > A class for Syntax was added rather than a more simple addSyntax("example
> > query", "description") API in AbstractRunner so that we can extend what
> > is associated with Syntax in future versions if we wish. It also opens
> > the door for runners to subclass Syntax and have the syntax objects
> > update dynamically based on settings or environment.
> >
> > apidox are missing.
> >
> >
> > Diffs
> > -----
> >
> >   trunk/KDE/kdelibs/plasma/abstractrunner.h 938702
> >   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 938702
> >   trunk/KDE/kdelibs/plasma/runnermanager.cpp 938756
> >
> > Diff: http://reviewboard.kde.org/r/372/diff
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Aaron
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel

-- 
-------------------

Dario Freddi
KDE Developer
GPG Key Signature: 511A9A3B

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090324/b6f54616/attachment.sig