Review Request: New option for plasma Notes

Zareth moux2003 at hotmail.com
Mon Mar 23 15:15:43 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/366/
-----------------------------------------------------------

(Updated 2009-03-23 07:15:43.226988)


Review request for Plasma.


Changes
-------

I made changes according to the comments. (for the not proper english name sorry, but I'm not english)
Everything seems good (for the line 124 of the notes.h concerning the "Plasma::TextEdit", it's a subclass created by the one how did the Notes plasma)


Summary
-------

This patch add to the plasmoid notes the possibility to choose a background color 
different from the general background of the Notes plasmoid for the line that is currently edited.

The idea came from a bug track concerning the bad view of the Notes when we choose a black
background color because we can't see the cursor. This option is an alternative to the problem.

If you notice any problems with this new option just tell me


Diffs (updated)
-----

  trunk/KDE/kdeplasma-addons/applets/notes/notes.h 943151 
  trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 943151 
  trunk/KDE/kdeplasma-addons/applets/notes/config.ui 943151 

Diff: http://reviewboard.kde.org/r/366/diff


Testing
-------


Screenshots
-----------

New option visual
  http://reviewboard.kde.org/r/366/s/65/


Thanks,

Zareth



More information about the Plasma-devel mailing list