Review Request: recycle unused containments if possible when assigning them to views

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/338/#review513
-----------------------------------------------------------

Ship it!


nice elegant solution.

- Aaron


On 2009-03-15 14:32:43, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/338/
> -----------------------------------------------------------
> 
> (Updated 2009-03-15 14:32:43)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this adds findFreeContainment that founds the first unused desktop containment by any view, so checkScreen uses it instead of creating a new one every time.
> so it's possible when switching to pervirtualdesktopviews to recycle unused stuff instead of creating 3 new containments everytime, important if it will be supported (as the preliminary patch i did) to switch on the fly to that mode while plasma is running.
> it could be used also to implement the support to the deletion of the active desktop containment
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/desktopcorona.h 938681 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/desktopcorona.cpp 939686 
> 
> Diff: http://reviewboard.kde.org/r/338/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>