Review Request: Add grouping support to extenders and use this feature in the systemtray to group jobs.

[Rob Scheepmaker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/344/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

I've been working on adding support for grouping to extenders and using this to group jobs in the plasma systemtray: a useful feature we already discussed at Tokamak. I've already discussed the extender api bit at Tokamak with Aaron, but changed a couple of things about it while implementing because they could have been more elegant. There are still some relatively minor problems I know of, and it hasn't been that thoroughly tested yet, but I wanted to see if you think I'm going in the right direction here.

The basic idea is that to group extender items, you'll instantiate an ExtenderGroup, which is a subclass of ExtenderItem. The thing this class adds, are expand and collapse buttons, to show/hide the items that belong to this group, and the ability to let the group automatically hide itself whenever it becomes empty. To add items to a group you'll have to call setGroup on each ExtenderItem you wish to add to that group. This association with a group will get stored in the item's config(). For the rest it behaves like any other extender item. 

I will still have to add behavior that automatically moves all items belonging to this group with it, whenever you detach the ExtenderGroup. Also, the usage of groups in systemtray could still use improvement.

Screenshot showing the job grouping in action: http://quartz.student.utwente.nl/~rob/extendergrouping.png Clicking the arrow-down here would collapse this group (keeping only the total progress item)


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/CMakeLists.txt 939911 
  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/job.h 939911 
  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/manager.h 939911 
  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/manager.cpp 939911 
  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 939911 
  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/jobwidget.cpp 939911 
  /trunk/KDE/kdelibs/plasma/CMakeLists.txt 939911 
  /trunk/KDE/kdelibs/plasma/applet.h 939911 
  /trunk/KDE/kdelibs/plasma/extender.h 939911 
  /trunk/KDE/kdelibs/plasma/extender.cpp 939911 
  /trunk/KDE/kdelibs/plasma/extendergroup.h PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/extendergroup.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/plasma/extenderitem.h 939911 
  /trunk/KDE/kdelibs/plasma/extenderitem.cpp 939911 
  /trunk/KDE/kdelibs/plasma/private/extenderitem_p.h 939911 

Diff: http://reviewboard.kde.org/r/344/diff


Testing
-------


Thanks,

Rob