Review Request: Check file timestamp on Plasma::Svg cache

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/343/#review497
-----------------------------------------------------------

Ship it!


to me looks good

- Marco


On 2009-03-16 07:03:26, Arthur Mello wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/343/
> -----------------------------------------------------------
> 
> (Updated 2009-03-16 07:03:26)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add support to check with file timestamp if cache for Plasma::Svg is still valid. Today a entry on cache is discarded only if we have a Theme/Colour change. This way if the svg file is changed a plasmoid will keep using the old image. The file timest
> amp is checked only on setImagePath to avoid a overhead every time a svg is loaded.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/svg.cpp 940045 
>   /trunk/KDE/kdelibs/plasma/theme.h 940045 
>   /trunk/KDE/kdelibs/plasma/theme.cpp 940045 
> 
> Diff: http://reviewboard.kde.org/r/343/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arthur
> 
>