Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/246/#review452
-----------------------------------------------------------


whenever a new source is added in the engine, the sourceAdded signal will be emitted; likewise, the sourceRemoved signal will be emitted whenever a source is removed. the applet should listen to those signals and manage its connections that way.

the engine half of the patch, however, can go in (without the signal)


/trunk/KDE/kdebase/workspace/plasma/applets/system-monitor/net.cpp
<http://reviewboard.kde.org/r/246/#comment283>

    yes, this is incorrect. new monitors will be added in the engine and that will cause a sourceAdded signal to be emitted. the widget should connect to the sourceAdded signal from Plasma::DataEngine.
    
    also, the 2000ms time out might be a bit long; 1000ms should be enough and make it feel a bit more responsive.


- Aaron


On 2009-03-07 10:35:00, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/246/
> -----------------------------------------------------------
> 
> (Updated 2009-03-07 10:35:00)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The System Monitor - Network applet is not aware of any new interfaces added, i.e. if a dial-up modem is connected, ppp0 didn't show up in the interfaces list until the applet is closed and started again.
> This patch enables the applet to be aware of such changes, and update the list accordingly.
> 
> 
> This addresses bug 184893.
>     https://bugs.kde.org/show_bug.cgi?id=184893
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/system-monitor/net.h 935835 
>   /trunk/KDE/kdebase/workspace/plasma/applets/system-monitor/net.cpp 935835 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/systemmonitor/systemmonitor.h 935835 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/systemmonitor/systemmonitor.cpp 935835 
> 
> Diff: http://reviewboard.kde.org/r/246/diff
> 
> 
> Testing
> -------
> 
> Tested with a dial-up modem. List is updated in 2 seconds after the new interface comes into existence, or is disconnected.
> 
> 
> Thanks,
> 
> Shantanu
> 
>