Review Request: Move dragEnter and dragMove events showing of drop zone from panelview to containment.

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/261/#review451
-----------------------------------------------------------

Ship it!


my concern was that this isn't appropriate for all Containment subclasses, but i suppose in that case the Containment can override the drag enter/move events as well.

- Aaron


On 2009-03-08 09:53:36, Rob Scheepmaker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/261/
> -----------------------------------------------------------
> 
> (Updated 2009-03-08 09:53:36)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Currently, the drop zone that's shown when hovering stuff over the panel, is being shown through a call to showDropZone from panelview. In those drag events, there is a check if what is hovering the panel, can actually be dropped there. Now that extenderitems also use QDrag, this if statement has already grown to 4 lines. I think it makes more sense to move this to containment, where that check is already being done, and avoid the duplication. This also avoids the need to use the "plasma/extenderitem" string in the mimetype check there, since in libplasma, we can use ExtenderItemMimeDate::mimeType() to obtain this string, and I would like to keep that class private.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.h 936720 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp 936720 
>   /trunk/KDE/kdelibs/plasma/containment.cpp 936720 
>   /trunk/KDE/kdelibs/plasma/extenderitem.cpp 936720 
> 
> Diff: http://reviewboard.kde.org/r/261/diff
> 
> 
> Testing
> -------
> 
> I've tested hovering different things over the panel, and the drop zone is shown as expected.
> 
> 
> Thanks,
> 
> Rob
> 
>