Review Request: add action collection to the corona

Chani chanika at gmail.com
Tue Mar 10 20:12:56 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/268/
-----------------------------------------------------------

(Updated 2009-03-10 12:12:56.043881)


Review request for Plasma and Marco Martin.


Changes
-------

checked for nulls, added actions() to corona, removed the qprivateslot because apparently that is BC


Summary
-------

some of the actions in Containment don't belong there, and there'll probably be more of those after the summer, so let's give them a home in Corona.
I've only moved over the lock action so far; I'll move the "new activity" one next.
Containment can grab the actions from the corona so the UI isn't affected by this patch and nothing breaks. there's just less duplicate actions. I'll leave the UI changes to notmart. :)


Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/containment.h 936946 
  trunk/KDE/kdelibs/plasma/containment.cpp 936946 
  trunk/KDE/kdelibs/plasma/corona.h 936946 
  trunk/KDE/kdelibs/plasma/corona.cpp 936946 
  trunk/KDE/kdelibs/plasma/private/containment_p.h 936946 

Diff: http://reviewboard.kde.org/r/268/diff


Testing
-------

works with desktop and screensaver.


Thanks,

Chani



More information about the Plasma-devel mailing list