Review Request: Enable System Monitor - Network to respond to newly connected network interfaces.

[Chani]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/246/#review442
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/applets/system-monitor/net.cpp
<http://reviewboard.kde.org/r/246/#comment273>

    this... feels wrong. like there should be a way to do it without adding signals to the dataengine, just using the regular dataUpdated stuff...
    aaron? what's the Right way to do this?


- Chani


On 2009-03-07 10:35:00, Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/246/
> -----------------------------------------------------------
> 
> (Updated 2009-03-07 10:35:00)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The System Monitor - Network applet is not aware of any new interfaces added, i.e. if a dial-up modem is connected, ppp0 didn't show up in the interfaces list until the applet is closed and started again.
> This patch enables the applet to be aware of such changes, and update the list accordingly.
> 
> 
> This addresses bug 184893.
>     https://bugs.kde.org/show_bug.cgi?id=184893
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/system-monitor/net.h 935835 
>   /trunk/KDE/kdebase/workspace/plasma/applets/system-monitor/net.cpp 935835 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/systemmonitor/systemmonitor.h 935835 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/systemmonitor/systemmonitor.cpp 935835 
> 
> Diff: http://reviewboard.kde.org/r/246/diff
> 
> 
> Testing
> -------
> 
> Tested with a dial-up modem. List is updated in 2 seconds after the new interface comes into existence, or is disconnected.
> 
> 
> Thanks,
> 
> Shantanu
> 
>