Review Request: add action collection to the corona
Chani
chanika at gmail.com
Tue Mar 10 18:08:32 CET 2009
> On 2009-03-10 01:54:53, Marco Martin wrote:
> > trunk/KDE/kdelibs/plasma/corona.h, line 167
> > <http://reviewboard.kde.org/r/268/diff/1/?file=2158#file2158line167>
> >
> > perhaps would be useful an accessor for the whole action collection?
> > now from the ui i can call them by name, dunno how it will grow in the future
if we end up needing it, we can add it later. I don't want to expose more than necessary, especially since I can't take it back once it's released :)
- Chani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/268/#review432
-----------------------------------------------------------
On 2009-03-09 10:24:36, Chani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/268/
> -----------------------------------------------------------
>
> (Updated 2009-03-09 10:24:36)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Summary
> -------
>
> some of the actions in Containment don't belong there, and there'll probably be more of those after the summer, so let's give them a home in Corona.
> I've only moved over the lock action so far; I'll move the "new activity" one next.
> Containment can grab the actions from the corona so the UI isn't affected by this patch and nothing breaks. there's just less duplicate actions. I'll leave the UI changes to notmart. :)
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/plasma/containment.cpp 936946
> trunk/KDE/kdelibs/plasma/corona.h 936946
> trunk/KDE/kdelibs/plasma/corona.cpp 936946
>
> Diff: http://reviewboard.kde.org/r/268/diff
>
>
> Testing
> -------
>
> works with desktop and screensaver.
>
>
> Thanks,
>
> Chani
>
>
More information about the Plasma-devel
mailing list