Review Request: Tasks applet: group popup with real task items

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/256/
-----------------------------------------------------------

(Updated 2009-03-08 15:22:38.552515)


Review request for Plasma, Aaron Seigo and Marco Martin.


Changes
-------

resize the offscreenWidget instea of the popupDialog, fixes sizing issues


Summary
-------

This patch replaces the currently used TasksMenu with a Plasma::Dialog which shows the same LayoutWidget which is also used in the expanded group.
This makes it possible to use the right click menu on items in the popup.
I couldn't find any drawbacks compared to the previous TasksMenu.
Drag&Drop support for sorting and grouping is not implemented though also not really neccessary (but i think it would be possible).


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp 936929 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 936929 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 936929 

Diff: http://reviewboard.kde.org/r/256/diff


Testing
-------

Tested locally.
unfortunately i don't get theming with my svn installation so i couldn't test if it looks nice.


Thanks,

Christian