Review Request: Adds support for tabs to the comic applet

[Marco Martin]

> On 2009-03-08 13:11:10, Chani wrote:
> > /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp, line 446
> > <http://reviewboard.kde.org/r/251/diff/1/?file=2028#file2028line446>
> >
> >     so... your config dialog only allows you to configure the comic for the current tab? awww.
> >     well... I can't think of a better way anyways... maybe that's not such a bad idea...

maybe putting a tabbar in the config dialog that reflects the tabbar in the comic, it's gonna be ugly (usability and code wise) but well...


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/251/#review414
-----------------------------------------------------------


On 2009-03-07 12:00:29, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/251/
> -----------------------------------------------------------
> 
> (Updated 2009-03-07 12:00:29)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adds tabs to the comic applet, on default the tab bar is not shown.
> 
> Ctrl + Scrolling on the image also changes the tabs, that way you can hide the tab bar but still access the tabs.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/comic/appearanceSettings.ui 936459 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 936459 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 936459 
>   /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h 936459 
>   /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp 936459 
>   /trunk/KDE/kdeplasma-addons/applets/comic/imagewidget.cpp 936459 
> 
> Diff: http://reviewboard.kde.org/r/251/diff
> 
> 
> Testing
> -------
> 
> Works, though sometimes the tab bar disappears, especially when scrolling back. notmart could not reproduce it though, so maybe a local problem.
> 
> 
> Thanks,
> 
> Matthias
> 
>