Review Request: Create and destroy panels as their screens come and go

[Chani]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/264/#review410
-----------------------------------------------------------

Ship it!


+1
there's a bug or two on bko that this fixes iirc, close them when you commit :)


/trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp
<http://reviewboard.kde.org/r/264/#comment241>

    so... the panel containment is still running, there's just no view for it until the monitor is plugged back in?
    the only downside I see is that there's no way to actually delete that containment without plugging the screen back in or editing the rc-file.
    
    it'd be kinda awesome if we could just not load the containment at all until the screen shows up...



/trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp
<http://reviewboard.kde.org/r/264/#comment240>

    nitpick: that debug message threw me for a second. maybe s/panel/panelview/


- Chani


On 2009-03-08 11:03:53, Aike J Sommer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/264/
> -----------------------------------------------------------
> 
> (Updated 2009-03-08 11:03:53)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This delays creation of PanelView's until there is an actual screen for them. It also removes the views when the screen is removed.
> That solves a few problems with panels that have all empty sizes and are thus not visible even though they are positioned correctly when a screen is plugged in.
> This patch also removes a duplicate sanity-check and sets the size for panels to 100% if it is empty, so that panels which are saved in the appletsrc with a 0 size are visible again.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/desktopcorona.cpp 936453 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp 936453 
>   /trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp 936453 
> 
> Diff: http://reviewboard.kde.org/r/264/diff
> 
> 
> Testing
> -------
> 
> Did a couple of iterations with starting and stopping plasma, as well as adding and removing my second screen. In between i changed the size of the panel and added/removed applets.
> All changes were correctly saved and restored and it did not crash on me!! :-)
> 
> 
> Thanks,
> 
> Aike J
> 
>