Review Request: Tasks applet: group popup with real task items
Christian Mollekopf
chrigi_1 at fastmail.fm
Sun Mar 8 11:24:55 CET 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/256/
-----------------------------------------------------------
Review request for Plasma, Aaron Seigo and Marco Martin.
Summary
-------
This patch replaces the currently used TasksMenu with a Plasma::Dialog which shows the same LayoutWidget which is also used in the expanded group.
This makes it possible to use the right click menu on items in the popup.
I couldn't find any drawbacks compared to the previous TasksMenu.
Drag&Drop support for sorting and grouping is not implemented though also not really neccessary (but i think it would be possible).
Diffs
-----
/trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp 936639
/trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 936639
/trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 936639
Diff: http://reviewboard.kde.org/r/256/diff
Testing
-------
Tested locally.
unfortunately i don't get theming with my svn installation so i couldn't test if it looks nice.
Thanks,
Christian
More information about the Plasma-devel
mailing list