Review Request: Nepomuk implementation for the comic applet

Matthias Fuchs mat69 at gmx.net
Tue Mar 3 14:46:26 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/207/
-----------------------------------------------------------

(Updated 2009-03-03 05:46:26.532132)


Review request for Plasma.


Changes
-------

Updated the diffs.


Summary
-------

When manually saving comics (context menu) additional information is stored using Nepomuk.

I'm not sure if the ontologies I use are the right ones (like subject) for what I do. Neither am I sure if the comic strip name (like XKCD) should be a tag itself rather than only the subject.

Please also look at the CMakeLists.txt file if I did it correctly.


Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/CMakeLists.txt 934589 
  /trunk/KDE/kdeplasma-addons/applets/comic/CMakeLists.txt 934589 
  /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 934589 
  /trunk/KDE/kdeplasma-addons/applets/comic/config-nepomuk.h.cmake PRE-CREATION 

Diff: http://reviewboard.kde.org/r/207/diff


Testing
-------

Seems to work nice.


Thanks,

Matthias



More information about the Plasma-devel mailing list