Review Request: scroller widget

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/225/#review341
-----------------------------------------------------------

Ship it!


other than not deleting the widget when setting a new one (and therefore making the mildly confusing apidox on that issue irrelevant :) it looks good.


/trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp
<http://reviewboard.kde.org/r/225/#comment210>

    why not "delete d->widget"?


- Aaron


On 2009-03-02 14:06:11, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/225/
> -----------------------------------------------------------
> 
> (Updated 2009-03-02 14:06:11)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is the second part of http://www.notmart.org/misc/microblogging-scroll.ogv is a widget that puts a scrollbar and allows the contents to scroll when content is bigger than the widget itself
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/CMakeLists.txt 932222 
>   /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/225/diff
> 
> 
> Testing
> -------
> 
> works quite well, except from the fact it doesnt receive events anymore after zooming out and zoomin back in, due to a qt bug of strange interactions between itemclipschildrentoshape and ignoring transforms items (handed a basic qtonly test case to alexis :p)
> 
> 
> Thanks,
> 
> Marco
> 
>