Review Request: borders of Plasma::Dialog dependent on screen edges
Marco Martin
notmart at gmail.com
Sun Mar 1 21:06:38 CET 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/206/
-----------------------------------------------------------
(Updated 2009-03-01 12:06:37.876513)
Review request for Plasma.
Changes
-------
add .h
Summary
-------
this makes all dialogs to not have the bottom border, not just the extender based ones.
also vertical borders are deactivated, this solves also the fitts law problem of kickoff
Diffs (updated)
-----
/trunk/KDE/kdelibs/dialog.h 932222
/trunk/KDE/kdelibs/dialog.cpp 932222
Diff: http://reviewboard.kde.org/r/206/diff
Testing
-------
tested with panels at four edges, extenders handling is leaved as it was (changed a bit the code to integrate with the other part, same algorithm)
Screenshots
-----------
http://reviewboard.kde.org/r/206/s/43/
Thanks,
Marco
More information about the Plasma-devel
mailing list