Review Request: Activate present windows from task group context menu

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/897/#review1400
-----------------------------------------------------------


i'm with Ivan on this one, i like the idea ... but i'm not comfortable with how it's being exposed to the user. there should probably be a way to select which effect is associated with the taskbar "show me these windows" effect. when this effect is enabled, it should also probably override the taskbar tooltips? finally, the context menu is pretty long already and it's a very slow way to access something that is really a shortcut. i do like the idea of a tooltip-replacing hover effect with one xatom to set with kwin deciding which effect gets employed. then plasma only needs to decide whether it sets that atom or shows the thumbnail tooltip.


trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp
<http://reviewboard.kde.org/r/897/#comment876>

    probably too much "geek speak": "what's 'present windows'"? :)
    
    perhaps just "present windows" or "show overview of windows" ... hm.. this will require some user testing i think.


- Aaron


On 2009-06-27 04:30:57, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/897/
> -----------------------------------------------------------
> 
> (Updated 2009-06-27 04:30:57)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Patch adds a new menu entry to task group context menu to show the group of windows in kwin's present windows effect. When this entry is selected the window ids of the tasks listed in the group are passed to an XAtom which activates present windows effect for the passed windows (other windows will be hidden). The atom will be removed by present windows effect when it get's disabled.
> 
> This patch requires current kwin from trunk. What's missing is the detection if present windows effect is available or not (e.g. compositing not active, Compiz used instead of KWin). KWin announces support via setting atom on root window.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 972097 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h 972097 
> 
> Diff: http://reviewboard.kde.org/r/897/diff
> 
> 
> Testing
> -------
> 
> Tested with both manual and automatic grouping.
> 
> 
> Thanks,
> 
> Martin
> 
>