Review Request: Fix Plasma clocks not being aware of timezone changes until next plasma-desktop restart, alt patch

Aaron Seigo aseigo at kde.org
Fri Jun 26 01:34:27 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/891/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Alternate patch to http://reviewboard.kde.org/r/889/ 

from 889: "The plasma timeengine reacts to timezone changes, but the timesource does not; this patch filles the gap."

the benefit of this patch is that the change is done in one place, no synchronization issues based on who gets a signal first. (i wonder if it needs to update all the timezones, even, or just the local one? not that updateAllSources is slow, so it shouldn't matter..)


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.h 980060 
  trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.cpp 980060 
  trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.h 980060 
  trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.cpp 980060 

Diff: http://reviewboard.kde.org/r/891/diff


Testing
-------


Thanks,

Aaron



More information about the Plasma-devel mailing list