Review Request: BackgroundListModel::removeBackground must be a slot but it wasn't

Aaron Seigo aseigo at kde.org
Fri Jun 26 01:12:49 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/883/#review1382
-----------------------------------------------------------


good catch; it can even go into protected slots, and this change needs to also be made to the two wallpapers that duplicate this code in plasma-addons. i'll take care of that .. thanks for patch :)

- Aaron


On 2009-06-25 02:38:01, Omer F. USTA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/883/
> -----------------------------------------------------------
> 
> (Updated 2009-06-25 02:38:01)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> @backgroundlistmodel.cpp: 
> connect(&m_dirwatch, SIGNAL(deleted(QString)), this, SLOT(removeBackground(QString)));
> 
> used as Slot but it wasn't defined as slot in .h file
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.h 986882 
> 
> Diff: http://reviewboard.kde.org/r/883/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Omer F.
> 
>



More information about the Plasma-devel mailing list