Review Request: Fix Plasma clocks not being aware of timezone changes until next plasma-desktop restart

Jacopo De Simoi wilderkde at gmail.com
Thu Jun 25 22:54:58 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/889/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

The plasma timeengine reacts to timezone changes, but the timesource does not; this patch filles the gap.

note the signal/slot/bool/updateslot dance is due to the fact that timesource could possibly get the update signal before KSystemTimeZone (and indeed it does) 


This addresses bugs not and reported?.
    https://bugs.kde.org/show_bug.cgi?id=not
    https://bugs.kde.org/show_bug.cgi?id=reported?


Diffs
-----

  branches/KDE/4.3/kdebase/workspace/plasma/dataengines/time/timesource.h 987201 
  branches/KDE/4.3/kdebase/workspace/plasma/dataengines/time/timesource.cpp 987201 

Diff: http://reviewboard.kde.org/r/889/diff


Testing
-------

Basic testing done and it works


Thanks,

Jacopo



More information about the Plasma-devel mailing list