Review Request: Place the user avatar next to the user/computer info in Kickoff

[J Janz]

I'm re-sending this e-mail 'cause it hit a size limit on plasma-devel ... =(
---------------------------------------------


2009/6/22 J Janz <jj at juniorjanz.net>

> In the subject, could I propose a slight change? I'm attaching a mockup.
> In that proposal, we can achieve a bigger picture (actually, the double of
> current's size), which users might always prefer. ;)
>
> I based it on Celeste's before patch image and haven't measured stuff in
> detail on it but the idea is the avatar spanning both rows, with user's name
> close to it and search a bit reduced and more far, having in the left the
> same margin width it has on the right (being visually separated from the
> avatar).
>
> What do you guys think of this?
>
> Cheers,
> --
> JJ (|´:¬{)»
> ---------------------------------------------
> "Eu sou a ressurreição e a vida. Quem crê em mim, ainda que morra, viverá;
> e todo o que vive e crê em mim não morrerá, eternamente. Crês isto?"
> O Senhor, Jesus Cristo - Jo.11:25-26
> ---------------------------------------------
>
>
> 2009/6/22 Jonathan Thomas <echidnaman at kubuntu.org>
>
>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviewboard.kde.org/r/870/
>> -----------------------------------------------------------
>>
>> Review request for Plasma.
>>
>>
>> Summary
>> -------
>>
>> In the KDE kickoff menu, the avatar currently appears next to the menu
>> search bar. It should be next to the username since the avatar and username
>> are related information. See screenshot.
>> (This is a seele-recommended fix, see https://launchpad.net/bugs/389744 )
>> Here's the before picture:
>> http://launchpadlibrarian.net/28128348/avatar.png
>>
>> The patch basically moves the search for the user icon to launcher.cpp,
>> and places either the found user icon-- or the generic user-identity icon if
>> none is found-- next to the user/computer info. The search icon has been
>> made smaller so that the new layout uses just as much space as the old
>> layout.
>>
>>
>> Diffs
>> -----
>>
>>  /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/searchbar.cpp
>> 978774
>>  /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
>> 978774
>>
>> Diff: http://reviewboard.kde.org/r/870/diff
>>
>>
>> Testing
>> -------
>>
>> I have tested it. It's a fairly straightforward patch.
>>
>>
>> Screenshots
>> -----------
>>
>> After
>>  http://reviewboard.kde.org/r/870/s/134/
>>
>>
>> Thanks,
>>
>> Jonathan
>>
>> _______________________________________________
>> Plasma-devel mailing list
>> Plasma-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20090622/77c73e9e/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: avatar2.jpg
Type: image/jpeg
Size: 38318 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090622/77c73e9e/attachment-0001.jpg