Review Request: design problem in the ocs dataengine and pachidermic patch

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/853/
-----------------------------------------------------------

(Updated 2009-06-17 13:25:48.792781)


Review request for Plasma.


Summary
-------

the ocs dataengine works in this way, when asking for a list of people like friends or nearby, it adds a new source for each person (and the applet reacts on sourceadded connecting to each new source) this is nice because the person source is quite clean and always with the same structure, but it has the following problem:
when a new person source arrives it's not possible to know who asked for this, so for instance if the opendesktop applet and the knowledgebase applet are loaded in the same time, when a query in the knowledgebase is performed it will use the person dataengine to fetch the avatars of the people who asked the questions, but this causes all those people to be added in the friend list of the opendesktop applet O.o
because the opendesktop applet has no way to understand that those people arrive from another kind of query

soo, this patch puts all the people into the Data of the query source, we'll have stuff like: Friends-foo that will contain Person-bar with all the data, Person-baz and so forth.

same treatment to KnowledgeBase

forgotten to say, it a really biig change to do right now, but i think the current behaviour has some potential problems that could be a bit nasty in the future


Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/opendesktop/opendesktop.h 979287 
  /trunk/KDE/kdeplasma-addons/applets/opendesktop/opendesktop.cpp 979287 
  /trunk/KDE/kdeplasma-addons/dataengines/ocs/ocsengine.h 982670 
  /trunk/KDE/kdeplasma-addons/dataengines/ocs/ocsengine.cpp 982670 

Diff: http://reviewboard.kde.org/r/853/diff


Testing
-------


Thanks,

Marco