Review Request: Density unit conversion

[Petri Damstén]

On Tuesday 02 June 2009 18:44:31 Aaron Seigo wrote:
> in the meantime, the i18n here looks very wrong. shouldn't it be:
>
> i18np("density unit", "ounce per cubic foot", "ounces per cubit foot", ..)?

No, currently unit takes arguments as (singular, plural, symbol, ...

> i seem to recall the translators being very unhappy with the conversion
> lib, and this is likely why ;) since there's a good amount of time to work
> on this between now and 4.4, how about creating a branch in svn to do this
> work, commit your patch (with the fixed yard -> foot thing) to that branch
> and then work on fixing the i18n? when 4.4 opens you can then merge the
> entire set of changes over into trunk/.

I have plans to make translation better in 4.4. I guess singular, plural 
strings should be a one KLocalizedString but I'm not sure if it can be used 
that way? Singular, plural are also needed as QStrings in a list so they can 
be matched against user given string in conversion runner.

Petri

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090602/36540bdf/attachment.sig