Review Request: Progress Widget in krunner

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/789/#review1259
-----------------------------------------------------------


i like the idea ... but i think we should consider how this is all being done a bit more. Jacopo has already talked a bit about the technical side of things, though i'm sure those are surmountable.

first, since we have a QGraphicsView for us to use, perhaps we should be using Plasma::BusyWidget so it's all consistent. in fact, i think that at this point we should move the _entire_ user interface into the scene. right now it's a mix of QWidgets and QGraphicsScene items.

there's also the issue of layout. we now have a row of two buttons, a line edit and two more buttons .. and then a spinner down below.

let's step back for a moment and thing about this interface a bit and consider how we can make it better / nicer. it's a bit early in they day here for that for me... but let's take this as a starting point for improving krunner's default interface for 4.4.

- Aaron


On 2009-06-02 03:06:37, jgoday wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/789/
> -----------------------------------------------------------
> 
> (Updated 2009-06-02 03:06:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Display a progress widget in krunner while performing the krunnermanager->query
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 976186 
>   /trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 976186 
> 
> Diff: http://reviewboard.kde.org/r/789/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> krunner
>   http://reviewboard.kde.org/r/789/s/127/
> 
> 
> Thanks,
> 
> jgoday
> 
>