Review Request: Window runner to switch windows and desktops

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1114/
-----------------------------------------------------------

(Updated 2009-07-28 15:06:18.013103)


Review request for Plasma.


Changes
-------

* fixed coding style with else
* use QHashIterator instead of foreach on keys()
* use new signals for preparing and cleanup


Summary
-------

This runner lists the windows and virtual desktops. It allows to activate a selected window or switch to a selected desktop. The runner works in the following way:
 * input is matched on window name, class or role; matching windows are listed
 * input is matched on desktop name. Matching desktops are shown for switching to, all windows on matching desktops are listed.
 * keyword "desktop": lists all desktops (except current) if additional number is inserted the list is reduced to that desktop
 * keyword "window": lists all windows. Additional text will be used to restrict like in first case. Following sub queries to restrict search are possible:
   * name=: restrict on name
   * class=: restrict on window class
   * role=: restrict on window role
   * desktop=: restrict on desktop
  those subqueries can be combined in any order. Each input not containing a '=' will be interpreted as a name restriction if there is no explicit name restriction. In that case it's ignored. Example query: "window desktop=2 class=kmail role=composer" will list all open KMail composer windows on desktop 2.


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.cpp PRE-CREATION 
  trunk/KDE/kdebase/workspace/plasma/runners/CMakeLists.txt 1003323 
  trunk/KDE/kdebase/workspace/plasma/runners/windows/CMakeLists.txt PRE-CREATION 
  trunk/KDE/kdebase/workspace/plasma/runners/windows/plasma-runner-windows.desktop PRE-CREATION 
  trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.h PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1114/diff


Testing
-------


Thanks,

Martin