Review Request: Fix layout problems in the pager applet

[Aaron Seigo]

> On 2009-07-27 00:08:35, Aaron Seigo wrote:
> > ok, this looks safe enough .. pls commit this to trunk, let's test it thoroughly there, and then we can backport it if/when no problems arise.
> 
> Anthony Bryant wrote:
>     Thanks! I don't actually have an svn account... Could you commit it for me?

sure :)

note that if you start submitting more patches, i'll be sending you over to http://techbase.kde.org/Contribute/Get_a_SVN_Account ;)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1124/#review1799
-----------------------------------------------------------


On 2009-07-25 21:40:41, Anthony Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1124/
> -----------------------------------------------------------
> 
> (Updated 2009-07-25 21:40:41)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch fixes a few problems with the pager that are especially apparent in vertical panels. Specifically, the rows and columns are unnecessarily swapped in recalculateGeometry() which causes bug 200013.
> Also, due to the way the rectangle sizes were calculated it was possible for certain areas to be clipped. This patch makes sure every item can fit into the current space.
> This also fixes a bug I only noticed when reading the code, where extra unnecessary columns could be added if desktopCount % rows > 1
> 
> My main concern about this patch is that it removes a mechanism for ignoring some constraints events, I think these events are needed in order to avoid clipping some of the virtual desktops, but I'm not sure how to reproduce the bug that made this filtering necessary in the first place.
> 
> 
> This addresses bug 200013.
>     https://bugs.kde.org/show_bug.cgi?id=200013
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.h 1002081 
>   /trunk/KDE/kdebase/workspace/plasma/applets/pager/pager.cpp 1002081 
> 
> Diff: http://reviewboard.kde.org/r/1124/diff
> 
> 
> Testing
> -------
> 
> Tested in vertical and horizontal panels and on the desktop.
> 
> 
> Thanks,
> 
> Anthony
> 
>