Review Request: Multiple actions support for Nepomuk Search Runner

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/689/#review1764
-----------------------------------------------------------

Ship it!


looks ok, and yes the camel case includes should be added.


trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.cpp
<http://reviewboard.kde.org/r/689/#comment1151>

    is this actually needed? shouldn't the catalog be automatically loaded?



trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/queryclientwrapper.cpp
<http://reviewboard.kde.org/r/689/#comment1152>

    no spaces in the ( )s 


- Aaron


On 2009-07-25 04:50:49, Ryan Bitanga wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/689/
> -----------------------------------------------------------
> 
> (Updated 2009-07-25 04:50:49)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Reposting patch for multiple actions support for the Nepomuk search runner. It adds open with and service menu actions to the nepomuk search runner. 
> 
> Now uses the new KFileItemActions and KFileItemListProperties and no longer depends on libkonq.
> 
> Minor style issue: the two new classes in KIO don't have camel case includes yet, and I wasn't sure if I should add them myself.
> 
> Another possible point for improvement: move the parseMenu method to AbstractRunner as something like an addActionsFromMenu method to reuse code between runners (useful for the locations runner and the window management runner which I'm thinking of moving into kdereview)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.h 999602 
>   trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.cpp 999602 
>   trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/queryclientwrapper.cpp 999602 
> 
> Diff: http://reviewboard.kde.org/r/689/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryan
> 
>