Review Request: Allow AbstractRunner to parse QMenus for actions

Ryan Bitanga ryan.bitanga at gmail.com
Sat Jul 25 03:24:26 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1115/
-----------------------------------------------------------

(Updated 2009-07-25 01:24:26.349811)


Review request for Plasma.


Changes
-------

cleaned the code per Chani's suggestions


Summary
-------

This adds a convenience method to AbstractRunner to extract a list of actions from a QMenu. Hierarchy is preserved by prefixing submenu text to the actions in the submenus.

Current uses are extracting actions from KFileItemActions and libtaskmanager. The code is currently used by the window management runner in playground, the multiple action nepomuk search runner patch in reviewboard, and fsrunner in kde-apps.org. This method will help avoid code duplication in these runners as well as future runners that can extract info from menus.


Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/abstractrunner.h 1001909 
  trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1001909 

Diff: http://reviewboard.kde.org/r/1115/diff


Testing
-------


Thanks,

Ryan



More information about the Plasma-devel mailing list